fix(exif): handle null byte padding after EXIF segment#24
Open
exoego wants to merge 1 commit intodiegomura:mainfrom
Open
fix(exif): handle null byte padding after EXIF segment#24exoego wants to merge 1 commit intodiegomura:mainfrom
exoego wants to merge 1 commit intodiegomura:mainfrom
Conversation
exoego
commented
Jan 26, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some JPEG files have null byte padding between segments that isn't accounted for in the segment length field.
This fix ensures the stream position is correctly advanced and skips any padding bytes.
Many JPEG decoders seem to handle this gracefully by scanning for the next 0xFF marker prefix.
This fix does the same - it's a robustness improvement for real-world malformed files.
This fixes foliojs/pdfkit#1175 and can be an advantage over jpeg-exif.
Note that I proposed jay-peg in foliojs/pdfkit#1678