Conversation
|
Thanks, it slipped out of my mind... |
no prob! I am cumulating it with other stuff anyways! |
|
this one is good to go, once reviewed I would propose to do a small patch due to the breaking #147 @DamienGilliard @eleniv3d . cheers! |
DamienGilliard
left a comment
DamienGilliard
left a comment
There was a problem hiding this comment.
Thanks @9and3. Only left a small question about compatibility of python versions, but otherwise all good with me
| diffCheck/df_transformations.py | ||
| diffCheck/df_util.py | ||
| diffCheck/df_visualization.py | ||
| diffCheck/diffcheck_bindings.cp39-win_amd64.pyd |
There was a problem hiding this comment.
Small question, could this python 3.12 bump cause problem with the python 3.9 Rhino uses in terms of compatibility ? I suppose not but you know better...
There was a problem hiding this comment.
what do you mean by python 3.12 bump? I believe we still wrap for 3.9 as in Rhino from the cmake, here:
Line 152 in a73bc9d
There was a problem hiding this comment.
Ah yes, right! sorry, my bad.
|
Looks good to me! |
3 participants
This is a simple patch to solve a couple of problems, notably #147 which is urgent, also a small hicup in the cmake ctesting running on ci.
fixes:
1. Error begin run: cannot import name 'diffcheck_bindings' from partially initialized module 'diffCheck' (most likely due to a circular import) (c:\users\localuser\diffcheck\src\gh\diffcheck\diffCheck\__init__.py) [9:1]