Add ICP registration as step of CAD segmentation#174
Merged
eleniv3d merged 10 commits intorelease/2.0.0from Feb 18, 2026
Merged
Add ICP registration as step of CAD segmentation#174eleniv3d merged 10 commits intorelease/2.0.0from
eleniv3d merged 10 commits intorelease/2.0.0from
Conversation
Collaborator
Author
|
Collaborator
Author
|
2026_02_12_data_experiment.zip Hi @eleniv3d I believe this PR is ready to be reviewed :) |
…ximum_face_segment_distance
eleniv3d
approved these changes
Feb 18, 2026
Collaborator
eleniv3d
left a comment
eleniv3d
left a comment
There was a problem hiding this comment.
there was one input missing from the metadata of the CAD_segmentator otherwise looks good!
Collaborator
Author
|
ah sorry I overlooked that... Thanks for fixing it ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now producing results such as these ones: