Skip to content

Fix/mypy check of setupdotpy #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DamienGilliard merged 2 commits into from
Feb 20, 2026
Merged

Fix/mypy check of setupdotpy #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5272035
fix-wip: force mypy version 1.19.1 to make sure all checks are done w…
DamienGilliard Feb 20, 2026
49e84e6
fix: int-float type hint mismatch in DFBeam class
DamienGilliard Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ repos:
files: \.py$

- repo: https://github.com/pre-commit/mirrors-mypy
rev: 'v1.11.1'
rev: 'v1.19.1'
hooks:
- id: mypy
files: (src/gh|tests|invokes\.py)
Expand Down
Binary file modified environment.yml
View file
Open in desktop
Binary file not shown.
10 changes: 5 additions & 5 deletions src/gh/diffCheck/diffCheck/df_geometries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,12 +579,12 @@ def compute_joint_angles(self) -> typing.List[float]:
angle = rg.Vector3d.VectorAngle(self.axis.Direction, joint_normal)
angle_degree = Rhino.RhinoMath.ToDegrees(angle)
jointfaces_angles.append(angle_degree)
angle_degree = int(angle_degree)
angle_degree = float(angle_degree)

if angle_degree > 90:
angle_degree = 180 - angle_degree
if angle_degree >= 89 and angle_degree <= 90:
angle_degree = -1
if angle_degree > 90.0:
angle_degree = 180.0 - angle_degree
if angle_degree >= 89.0 and angle_degree <= 90.0:
angle_degree = -1.0

jointface_angles.append(angle_degree)
return jointface_angles
Expand Down
Loading