Re-enable num-traits under an optional feature#7
Re-enable num-traits under an optional feature#7althonos wants to merge 2 commits intodiffeo:masterfrom
num-traits under an optional feature#7Conversation
|
Hmmm, I'm not so sure about this. What if Kodama's |
|
I don't think I could, because |
|
Yeah the problem is that I'm just not sure I want to take on the extra burden of supporting |
|
Ah, that's unfortunate. I thought this would be okay considering the trait was already implemented in the previous versions... |
Hi Andrew!
First of all thanks a lot for developing this crate, I've been able to move some more of our data analysis pipeline to Rust thanks to it.
While I can understand why you want to get rid of the
num-traitsdependency in your context (at least, from what I got from the commit message of f19d626), it's actually super practical to have it available because you can depend on custom float types, the most interesting one for me beingf16from thehalfcrate to work with a reduced memory footprint. The drop ofnum-traitssupport prevented me from updating tov0.3.This PR keeps the best of both worlds by hiding the
num-traitsdependency behind a feature gate, which is disabled by default. Users like me who want to use theFloattrait fromnum-traitscan enable the feature, but by defaultkodamaremains without dependency.