fix(commands): show validation errors in modal instead of globally#251
Open
JiahaoZhu11 wants to merge 5 commits intodifferent-ai:devfrom
Open
fix(commands): show validation errors in modal instead of globally#251JiahaoZhu11 wants to merge 5 commits intodifferent-ai:devfrom
JiahaoZhu11 wants to merge 5 commits intodifferent-ai:devfrom
Conversation
Display command validation errors in the modal footer rather than the global error banner. Adds commandModalError signal for modal-specific error state and clears error when modal is closed.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Contributor
Author
|
Hey @benjaminshafii, just realized I forgot to mark this one as "ready for review" earlier. This is another quick fix—would appreciate it when you have a moment to take a look. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
commandModalErrorsignal for modal-specific error stateerrorprop toCommandModalcomponentsaveCommandto use modal-specific error for validation failuresTest plan