feat(#2183): flexmark configuration support #2280
Conversation
| @@ -89,6 +89,7 @@ dependencies { | |||
| compatDiktat2Dot0Dot0CompileOnly "com.saveourtool.diktat:diktat-runner:2.0.0" | |||
| // flexmark | |||
| flexmarkCompileOnly 'com.vladsch.flexmark:flexmark-all:0.64.8' | |||
| implementation 'com.vladsch.flexmark:flexmark-util-data:0.64.8' | |||
There was a problem hiding this comment.
Has to be flexmarkCompileOnly, not implementation. Spotless has way too many dependencies to deal with all the transitive conflicts. You can only use flexmark classes inside of FlexmarkFormatterFunc, which gets called with a special classloader after Gradle/Maven has done the dependency resolution.
There was a problem hiding this comment.
@nedtwigg I'm a bit confused. If we 're using only flexmarkCompileOnly it means that I can't get access to flexmark-util-data API inside of FlexmarkStep, which makes it impossible to run with custom configuration or am I wrong?
There was a problem hiding this comment.
Hey, @l3r8yJ. It's been almost a year and I don't know if you still have the interest to finish this PR.
Anyway, you can find an example of the usage of classloader in JsonSimpleStep. You need to use com.diffplug.spotless.JarState and load the class at runtime.
| implementation 'com.vladsch.flexmark:flexmark-all:0.64.8' | ||
| implementation 'com.vladsch.flexmark:flexmark-util-data:0.64.8' |
| @@ -40,7 +40,7 @@ public class FlexmarkFormatterFunc implements FormatterFunc { | |||
| private final Parser parser; | |||
| private final Formatter formatter; | |||
|
|
|||
| public FlexmarkFormatterFunc() { | |||
| public FlexmarkFormatterFunc(final MutableDataHolder customFormatterOptions) { | |||
There was a problem hiding this comment.
As you mentioned, MutableDataHolder is not Serializable. So we can't use it as a parameter like Gson.
We need to pass Lists of String, like cleanthat, or anything with zero dependencies.
There was a problem hiding this comment.
This would be hard, since Flexmark reinvent the wheels...
| import java.io.Serializable; | ||
| import java.lang.reflect.Constructor; | ||
| import java.util.Objects; | ||
|
|
||
| import com.vladsch.flexmark.util.data.MutableDataHolder; | ||
| import com.vladsch.flexmark.util.data.MutableDataSet; |
There was a problem hiding this comment.
We need to load the classes at runtime.
| @@ -19,29 +19,38 @@ | |||
|
|
|||
| import javax.inject.Inject; | |||
|
|
|||
| import com.vladsch.flexmark.util.data.MutableDataSet; | |||
|
@qwertycxz so, If u're had an idea, go ahead please! |
|
@qwertycxz or I can finish it in couple of days... |
|
I have two ideas for this: Plan A: Let user create a Plan B: We take a parser option |
|
@qwertycxz I'll take a look at this a bit later and give an answer for you tomorrow or later today |
WIP PR,
closes #2183