fix: prevent race conditions for concurrent npm-based server processes using same node_modules dir
#2786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2462 and #2542 we added support for multiple npm-based formatters sharing the same
node_modulesdirectory.In my projects I noticed that - every once in a while - some of the npm-server-processes failed to start. This happened more often when configuration cache was active (and hence processes started faster). The lint files showed the following messages (example):
This PR fixes this race condition by making sure that the server-processes do not collide on the
server.port.tmpfile anymore, no matter the timing.