Skip to content

Conversation

@bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Dec 9, 2024

Screenshot 2024-12-09 at 6 13 30 PM

@sbillinge @cadenmyers13 Working now, using the same reusable workflow.

https://bobleesj.github.io/diffpy.fourigui/api/diffpy.fourigui.html

After merged, please deploy doc by workflow dispatch!

@github-actions
Copy link

github-actions bot commented Dec 9, 2024

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

@codecov
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (2610788) to head (8ee9836).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files           4        4           
  Lines         177      177           
=======================================
  Hits          166      166           
  Misses         11       11           

@bobleesj
Copy link
Contributor Author

https://github.com/diffpy/diffpy.fourigui/blob/main/news/h5py.rst

No additional news is created since a news file has been created above.

@sbillinge sbillinge merged commit cb0a441 into diffpy:main Dec 10, 2024
4 of 5 checks passed
@bobleesj bobleesj deleted the patch-3 branch December 10, 2024 05:01
@bobleesj
Copy link
Contributor Author

@sbillinge https://github.com/diffpy/diffpy.fourigui/actions/workflows/publish-docs-on-release.yml

seems like github pages was deployed but the workflow wasn't

@sbillinge
Copy link
Contributor

sorry, try again. its 5 am here....not functioning at full capacity

@sbillinge
Copy link
Contributor

still didn't build properly? Not sure why. Too hard to debug on little sleep and train wifi...

@bobleesj
Copy link
Contributor Author

Screenshot 2024-12-10 at 9 42 28 AM

The workflow name is called Deploy Documentation on Release - could you pls run from this URL: https://github.com/diffpy/diffpy.fourigui/actions/workflows/publish-docs-on-release.yml ?

@bobleesj
Copy link
Contributor Author

(I see that the last run was done 4 days ago for Deploy Documentation on Release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants