[AMIEQueue] Add progress bar for each generation#45
[AMIEQueue] Add progress bar for each generation#45falcaopetri wants to merge 2 commits intodig-team:masterfrom
Conversation
|
Note that I've implemented the Progress Bar to update during I did not realize that at implementation time. My consideration was only that:
An alternative implementation would move the responsibility of the ProgressBar to AMIE. This would require adding a lock (which is easy to do). This way, we would reach 100% only after processing all available rules. |
|
Hi, I like the idea of the progress bar. I also think As for the 100% progress problem, the number of processed rules should always be equal to: "number of dequeues" - "number of active threads" and this last number is always equal to Jonathan |

This PR modifies the
AMIEQueuesuch that it reports the mining progress using a progress bar (if-verbose).I've used the most active Java CLI progress bar I cound find (https://github.com/ctongfei/progressbar).
One (minor?) issue is that AMIE's logging conflicts with the line breaks, yielding some lines with both progressbar and AMIE logging. I think the only solution would be to use some logging module and redirect the different output types to different files.
I've also used a heuristic to set how often the progress bar should be updated. It seems to work on my small experiments, but I will still test it with bigger datasets.
I'm not sure yet about the overhead added by this (i) if verbose is not set, (ii) if verbose is set.