Skip to content

update dcv and validation exception to include dnssec#104

Merged
jared-daniels merged 2 commits intomasterfrom
update-dcvException-dnssec-details
Feb 12, 2026
Merged

update dcv and validation exception to include dnssec#104
jared-daniels merged 2 commits intomasterfrom
update-dcvException-dnssec-details

Conversation

@tando-nxiweni
Copy link
Copy Markdown
Contributor

🎯 Summary

Enhanced the Domain Control Validation exception classes to capture and propagate DNSSEC validation details when DNS lookup failures occur. This improvement provides better error diagnostics and debugging capabilities for DNSSEC-related validation failures.

🔑 Key Changes

Exception Enhancements

  • DcvException: Added dnssecDetails field and new constructor to support DNSSEC error information
  • ValidationException: Added constructor overload to accept and propagate DNSSEC details

Validator Updates

  • DnsValidator: Modified to extract and pass DNSSEC details when DNS_LOOKUP_DNSSEC_FAILURE error occurs

Test Coverage

  • Added unit test testDnsValidator_validate_dnssec_dnskey_missing() to verify DNSSEC failure handling

📋 Checklist

  • Code follows project style guidelines
  • Unit tests added/updated
  • All tests passing
  • JavaDoc documentation updated
  • Backward compatibility maintained
  • No breaking changes

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enhances DNS Domain Control Validation (DCV) error reporting by propagating DNSSEC validation details through DCV/validation exceptions when DNSSEC-related lookup failures occur, improving diagnostics for DNSSEC failures.

Changes:

  • Added DnssecDetails propagation support to DcvException / ValidationException via new constructor overloads.
  • Updated DnsValidator to extract dnssecDetails from MPIC details when DNS_LOOKUP_DNSSEC_FAILURE is present and include it in thrown ValidationException.
  • Added a unit test covering the DNSSEC failure path in DnsValidator.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
library/src/main/java/com/digicert/validation/exceptions/DcvException.java Adds dnssecDetails field and constructor overload to carry DNSSEC diagnostics on DCV exceptions.
library/src/main/java/com/digicert/validation/exceptions/ValidationException.java Adds constructor overload to pass DNSSEC details through validation exceptions.
library/src/main/java/com/digicert/validation/methods/dns/DnsValidator.java Extracts DNSSEC details on DNSSEC lookup failures and includes them in thrown ValidationException.
library/src/test/java/com/digicert/validation/methods/dns/DnsValidatorTest.java Adds a DNSSEC failure-focused test case for DnsValidator.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tando-nxiweni tando-nxiweni force-pushed the update-dcvException-dnssec-details branch from ddceacb to b554817 Compare February 11, 2026 17:32
@jared-daniels jared-daniels merged commit f642035 into master Feb 12, 2026
3 checks passed
@jared-daniels jared-daniels deleted the update-dcvException-dnssec-details branch February 12, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants