update dcv and validation exception to include dnssec#104
Merged
jared-daniels merged 2 commits intomasterfrom Feb 12, 2026
Merged
update dcv and validation exception to include dnssec#104jared-daniels merged 2 commits intomasterfrom
jared-daniels merged 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Enhances DNS Domain Control Validation (DCV) error reporting by propagating DNSSEC validation details through DCV/validation exceptions when DNSSEC-related lookup failures occur, improving diagnostics for DNSSEC failures.
Changes:
- Added
DnssecDetailspropagation support toDcvException/ValidationExceptionvia new constructor overloads. - Updated
DnsValidatorto extractdnssecDetailsfrom MPIC details whenDNS_LOOKUP_DNSSEC_FAILUREis present and include it in thrownValidationException. - Added a unit test covering the DNSSEC failure path in
DnsValidator.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
library/src/main/java/com/digicert/validation/exceptions/DcvException.java |
Adds dnssecDetails field and constructor overload to carry DNSSEC diagnostics on DCV exceptions. |
library/src/main/java/com/digicert/validation/exceptions/ValidationException.java |
Adds constructor overload to pass DNSSEC details through validation exceptions. |
library/src/main/java/com/digicert/validation/methods/dns/DnsValidator.java |
Extracts DNSSEC details on DNSSEC lookup failures and includes them in thrown ValidationException. |
library/src/test/java/com/digicert/validation/methods/dns/DnsValidatorTest.java |
Adds a DNSSEC failure-focused test case for DnsValidator. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
library/src/test/java/com/digicert/validation/methods/dns/DnsValidatorTest.java
Show resolved
Hide resolved
library/src/test/java/com/digicert/validation/methods/dns/DnsValidatorTest.java
Outdated
Show resolved
Hide resolved
library/src/main/java/com/digicert/validation/exceptions/ValidationException.java
Outdated
Show resolved
Hide resolved
library/src/main/java/com/digicert/validation/methods/dns/DnsValidator.java
Outdated
Show resolved
Hide resolved
ddceacb to
b554817
Compare
jared-daniels
approved these changes
Feb 12, 2026
shamaneta
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Summary
Enhanced the Domain Control Validation exception classes to capture and propagate DNSSEC validation details when DNS lookup failures occur. This improvement provides better error diagnostics and debugging capabilities for DNSSEC-related validation failures.
🔑 Key Changes
Exception Enhancements
dnssecDetailsfield and new constructor to support DNSSEC error informationValidator Updates
DNS_LOOKUP_DNSSEC_FAILUREerror occursTest Coverage
testDnsValidator_validate_dnssec_dnskey_missing()to verify DNSSEC failure handling📋 Checklist