Update DnssecError.IO_EXCEPTION for failure due to I/O error during DNS resolution#105
Merged
jared-daniels merged 3 commits intomasterfrom Feb 25, 2026
Merged
Update DnssecError.IO_EXCEPTION for failure due to I/O error during DNS resolution#105jared-daniels merged 3 commits intomasterfrom
jared-daniels merged 3 commits intomasterfrom
Conversation
jared-daniels
previously approved these changes
Feb 24, 2026
yunruiwatts
reviewed
Feb 24, 2026
library/src/test/java/com/digicert/validation/exceptions/AcmeValidationExceptionTest.java
Outdated
Show resolved
Hide resolved
jared-daniels
approved these changes
Feb 25, 2026
yunruiwatts
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new error type IO_EXCEPTION to the DnssecError enum to specifically handle I/O errors that occur during DNS resolution in DNSSEC validation processes.
Changes
1. DnssecError Enum Enhancement
File:
library/src/main/java/com/digicert/validation/mpic/api/dns/DnssecError.javaIO_EXCEPTIONRRSIGS_MISSINGandOTHERenum valuesExisting DnssecError Values:
DNSKEY_MISSING- DNSKEY record is missing at the zoneDNSSEC_BOGUS- DNSSEC validation resulted in BOGUS statusNSEC_MISSING- NSEC or NSEC3 record is missing for denial of existence proofRRSIGS_MISSING- RRSIG records are missing for the requested record typeIO_EXCEPTION← NEWOTHER- Other unspecified DNSSEC errorMotivation
The addition of
IO_EXCEPTIONprovides more granular error reporting for DNSSEC validation failures. Previously, I/O errors during DNS resolution would have been categorized under the genericOTHERerror type. This new specific error type allows:Use Cases
The
IO_EXCEPTIONerror type is particularly useful for scenarios such as:Integration Points
1. DnssecDetails Record
The
IO_EXCEPTIONerror is part of theDnssecDetailsrecord structure:2. Exception Handling
Used in validation exceptions (
ValidationException,AcmeValidationException) to provide detailed DNSSEC error information alongside general DCV errors.3. DNS Lookup Flow
When DNS lookup encounters an
IOException:DnsClientcatches the exceptionClientStatus.DNS_LOOKUP_IO_EXCEPTIONDcvError.DNS_LOOKUP_IO_EXCEPTIONDnssecError.IO_EXCEPTIONTesting
The change includes test coverage in:
AcmeValidationExceptionTest.java- Tests exception handling withIO_EXCEPTIONerrorDnssecStatus.INDETERMINATEfor cases where validation cannot be completedRelated Enums
ClientStatus (DNS operations)
DNS_LOOKUP_IO_EXCEPTION- General I/O exception during DNS lookupDcvError (Domain Control Validation)
DNS_LOOKUP_IO_EXCEPTION- I/O exception at DCV levelDNS_LOOKUP_DNSSEC_FAILURE- General DNSSEC failureDnssecError (DNSSEC-specific)
IO_EXCEPTION- NEW: I/O error specifically in DNSSEC validation context