Added support for RSASSA-PSS signature validation (#182)#183
Merged
CBonnell merged 6 commits intodigicert:mainfrom Feb 26, 2026
Merged
Added support for RSASSA-PSS signature validation (#182)#183CBonnell merged 6 commits intodigicert:mainfrom
CBonnell merged 6 commits intodigicert:mainfrom
Conversation
CBonnell
reviewed
Feb 12, 2026
tests/integration_certificate/pkix/rsa_self_signed_rsassapss_sig.crttest
Show resolved
Hide resolved
Collaborator
|
Hi @Pearmint, thanks for this PR! I added a few comments to specific lines, but can you also merge the "main" branch into your PR branch? It appears that there's been some changes to the Black code format recently that need to be incorporated for the CI pipeline to succeed. |
CBonnell
reviewed
Feb 12, 2026
tests/integration_certificate/pkix/rsa_self_signed_rsaasspss_sig.crttest
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Hi @CBonnell, |
CBonnell
reviewed
Feb 24, 2026
Collaborator
|
Looks good but I think we need to future-proof how we obtain the salt length. I offered a proposal in an inline comment -- let know if you want to make that change, or if you prefer that I do that in a separate PR. |
CBonnell
approved these changes
Feb 26, 2026
Collaborator
CBonnell
left a comment
CBonnell
left a comment
There was a problem hiding this comment.
Looks good, thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for RSASSA-PSS signature validation (#182)