Skip to content

Adding step to upload valgrind report in integration tests #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sushmitha-MN wants to merge 2 commits into
base: main
Choose a base branch
from
+32 −1
Open

Adding step to upload valgrind report in integration tests #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1304a8
Adding step to upload valgrind report in integration tests
Sushmitha-MN Mar 29, 2026
a2d6735
Removing hardcoded branch
Sushmitha-MN Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/nanocert_est_integration_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,14 @@ jobs:
echo "Coverage Summary:"
lcov --list /tmp/est_total.info

- name: Upload Valgrind Report Artifact
if: always()
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
with:
name: report_valgrind_client
path: report_valgrind_client.zip
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

report_valgrind_client.zip is uploaded here, but there is no step in this workflow that creates that file. If est_sample.py doesn’t reliably generate it, artifact upload will warn or fail. Consider adding an explicit zip step (or uploading the report directory directly) and/or setting if-no-files-found explicitly.

Suggested change
path: report_valgrind_client.zip
path: report_valgrind_client
if-no-files-found: warn

Copilot uses AI. Check for mistakes.
retention-days: 5

- name: Cleanup mocn-qa-m-products
run: |
rm -rf ~/mocn-qa-m-products
9 changes: 8 additions & 1 deletion .github/workflows/nanocert_scep_integration_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
name: "NanoCert SCEP Integration Tests"

on:
workflow_dispatch: {}

Expand Down Expand Up @@ -79,6 +78,14 @@ jobs:
echo "Coverage Summary:"
lcov --list /tmp/scep_total.info

- name: Upload Valgrind Report Artifact
if: always()
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
with:
name: report_valgrind_client
path: report_valgrind_client.zip
Comment on lines 80 to +86
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

report_valgrind_client.zip is uploaded here, but this workflow doesn’t create that zip anywhere. If scep_client.py doesn’t always produce it, this upload step will warn or fail. Consider adding an explicit zip step (or uploading the report directory directly) and/or setting if-no-files-found to the desired behavior.

Suggested change
- name: Upload Valgrind Report Artifact
if: always()
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
with:
name: report_valgrind_client
path: report_valgrind_client.zip
- name: Archive Valgrind Report
if: always()
run: |
if [ -d "report_valgrind_client" ]; then
echo "Zipping Valgrind report directory into report_valgrind_client.zip"
zip -r report_valgrind_client.zip report_valgrind_client
else
echo "No report_valgrind_client directory found; skipping archive creation."
fi
- name: Upload Valgrind Report Artifact
if: always()
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
with:
name: report_valgrind_client
path: report_valgrind_client.zip
if-no-files-found: warn

Copilot uses AI. Check for mistakes.
retention-days: 5

- name: Cleanup mocn-qa-m-products
run: |
rm -rf ~/mocn-qa-m-products
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/nanossh_integration_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,14 @@ jobs:
run: |
PYTHONUNBUFFERED=1 python3 run.py global_nanossh_cap_no_tap.json

- name: Upload Valgrind Report Artifact
if: always()
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
with:
name: report_valgrind
path: report_valgrind.zip
retention-days: 5
Comment on lines +69 to +75
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

report_valgrind.zip is uploaded here, but there is no step in this workflow that creates it. If the test run doesn’t reliably generate that file, artifact upload will warn or fail. Consider zipping the report explicitly before upload (or upload the report directory) and/or set if-no-files-found explicitly.

Copilot uses AI. Check for mistakes.

- name: Cleanup mocn-qa-m-products
if: always()
run: |
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/nanossl_integration_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,14 @@ jobs:
CM_ENV_CODE_COVERAGE: 1
run: |
python3 nanossl_integration_test.py build_server_cap_no_tap.json

- name: Upload Valgrind Report Artifact
if: always()
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
with:
name: report_valgrind
path: report_valgrind.zip
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

report_valgrind.zip is uploaded here, but this workflow file doesn’t create it anywhere. If the integration test script doesn’t always generate that zip, this step will at best emit warnings (or fail, depending on action defaults). Consider adding an explicit step to create the zip (or upload the report_valgrind/ directory directly) and/or set if-no-files-found to the intended behavior (ignore/warn/error).

Suggested change
path: report_valgrind.zip
path: report_valgrind/
if-no-files-found: warn

Copilot uses AI. Check for mistakes.
retention-days: 5

- name: Baseline Coverage
run: |
Expand Down
Loading