Skip to content

fix(notion): refine spacer transformer and spacing#65

Merged
luandro merged 3 commits intomainfrom
codex/github-mention-empty-blocks-use-to-add-space-between-conte
Nov 6, 2025
Merged

fix(notion): refine spacer transformer and spacing#65
luandro merged 3 commits intomainfrom
codex/github-mention-empty-blocks-use-to-add-space-between-conte

Conversation

@luandro
Copy link
Contributor

@luandro luandro commented Nov 5, 2025

Summary

Testing

  • bunx vitest run scripts/notionClient.test.ts (fails: registry returned 429 rate limit)

https://chatgpt.com/codex/tasks/task_e_690b97ff619c8327a49d6b4637527aab

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

🚀 Preview Deployment

Your documentation preview is ready!

Preview URL: https://pr-65.comapeo-docs.pages.dev

This preview will update automatically when you push new commits to this PR.


Built with commit d023dc6

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@digidem digidem deleted a comment from github-actions bot Nov 5, 2025
@luandro luandro marked this pull request as draft November 6, 2025 01:52
@luandro luandro force-pushed the codex/github-mention-empty-blocks-use-to-add-space-between-conte branch from 8f4caa0 to 5e76356 Compare November 6, 2025 11:40
@luandro luandro marked this pull request as ready for review November 6, 2025 11:41
@luandro luandro merged commit 0a98a95 into main Nov 6, 2025
4 of 6 checks passed
@luandro luandro deleted the codex/github-mention-empty-blocks-use-to-add-space-between-conte branch November 6, 2025 11:42
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

🧹 Preview Deployment Cleanup

The preview deployment for this PR has been cleaned up.

Preview URL was: https://pr-65.comapeo-docs.pages.dev


Note: Cloudflare Pages deployments follow automatic retention policies. Old previews are cleaned up automatically.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +322 to +323
try {
return defaultParagraphToMarkdown(paragraphBlock as BlockObjectResponse);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve nested indentation when delegating paragraph transform

The custom paragraphTransformer returns early for empty blocks and otherwise delegates to the original blockToMarkdown. However, the delegation at defaultParagraphToMarkdown(paragraphBlock as BlockObjectResponse) does not forward any of the extra arguments that NotionToMarkdown passes to custom transformers (e.g. the current nesting depth). As a result every non‑empty paragraph is rendered with a nesting level of 0, so paragraphs that appear inside list items, callouts, or other nested contexts lose their indentation in the generated Markdown. Accept the extra parameters (...args) and pass them along to defaultParagraphToMarkdown so nested paragraphs still render correctly.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant