Skip to content

chore: user zustand store for server state#1283

Open
gmaclennan wants to merge 1 commit intodevelopfrom
chore/sever-state-zustand
Open

chore: user zustand store for server state#1283
gmaclennan wants to merge 1 commit intodevelopfrom
chore/sever-state-zustand

Conversation

@gmaclennan
Copy link
Member

This is a non-urgent follow-up to #1279 to switch the implementation to use a zustand store. The functionality should be the same, but this reduces some boilerplate and matches our existing use of Zustand for stores.

@gmaclennan gmaclennan self-assigned this Jul 21, 2025
@ErikSin ErikSin requested a review from cimigree January 24, 2026 21:01
@cimigree cimigree marked this pull request as ready for review January 26, 2026 21:32
Copy link
Contributor

@cimigree cimigree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice this store doesn't use a context wrapper...
Is that because:
Testing this would require mocking the Node.js channel anyway?
Or should this eventually be wrapped in context for consistency?

But in the meantime, nice work reducing boilerplate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants