Closed
Conversation
Member
Author
|
switching to bare-make build was addressed in #1517. x64 builds of the app can be addressed in a separate PR if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches the prebuilds of better-sqlite3 to ones built with bare-make toolchain, instead of the previous node-gyp build. This seems to fix running the app on x86 architecture (previously the x86 builds of better-sqlite3 crashed the app).
The builds are generated by the updated workflow in digidem/better-sqlite3-nodejs-mobile#5, which was run manually with v11.10.0 of better-sqlite3 and the
11.10.0-bare-makerelease tag, so that the release would not conflict with the current node-gyp version we are using.The question remains about how to actually build this for dev using an x86 emulator. Currently I have just enabled building APKs for all architectures, but this increases the APK size significantly. Looking for input on how to only enable x86_64 arch for local dev builds, and keep production apks to arm-only.