Update attribution when adding layer after map is added to the DOM#30
Open
agorf wants to merge 1 commit intodigidem:gh-pagesfrom
Open
Update attribution when adding layer after map is added to the DOM#30agorf wants to merge 1 commit intodigidem:gh-pagesfrom
agorf wants to merge 1 commit intodigidem:gh-pagesfrom
Conversation
agorf
changed the title
diachedelic
reviewed
Jul 30, 2018
diachedelic
left a comment
diachedelic
left a comment
There was a problem hiding this comment.
This change should be made to index.js, not leaflet-bing-layer.js as that file is generated by npm run build
This fixes the attributions not being fetched and not showing initially when the map is added to the DOM and the layer is added to the map at a later point (e.g. on a button click).
Author
|
@diachedelic Fixed. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the attributions not being fetched and not showing initially when the map is added to the DOM and the layer is added to the map at a later point (e.g. on a button click).
Demo of the issue: https://jsfiddle.net/agorf/tphbuLvu/
To reproduce, once the demo page loads, click on the button to add the layer. You will notice the attribution is still missing (it's still left as "Leaflet"). It is correctly updated only once the map is moved.