Skip to content

Ensure attributions are correctly added/remove when layers are switched #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diachedelic wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

Ensure attributions are correctly added/remove when layers are switched #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8106ece
Ensure attributions appear after switching layers
jamesdiacono Oct 17, 2018
0ab92ba
Handle layer change during fetch
jamesdiacono Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ L.TileLayer.Bing = L.TileLayer.extend({
this._attributions.forEach(function (attribution) {
map.attributionControl.removeAttribution(attribution)
})
this._attributions = []
L.TileLayer.prototype.onRemove.call(this, map)
},

Expand Down Expand Up @@ -231,6 +232,9 @@ L.TileLayer.Bing = L.TileLayer.extend({
var zoom = map.getZoom()
var bbox = toBingBBox(map.getBounds().toBBoxString())
this._fetch.then(function () {
// Layer has been removed during fetch
if (!this._map) return

var newAttributions = this._getAttributions(bbox, zoom)
var prevAttributions = this._attributions
// Add any new provider attributions in the current area to the attribution control
Expand Down