Conversation
ErikSin
force-pushed
the
Es/fix-back-map-details
branch
from
5ad3510 to
23c9ac0
Compare
ErikSin
force-pushed
the
Es/fix-back-map-details
branch
from
23c9ac0 to
f741385
Compare
achou11
requested changes
Feb 21, 2023
| interface Props extends React.PropsWithChildren<{}> { | ||
| onDismiss: () => void; | ||
| onHardwareBackPress?: () => void; | ||
| onHardwareBackPress?: () => void | boolean; |
Member
There was a problem hiding this comment.
think this would need to be adjusted to this:
Suggested change
| onHardwareBackPress?: () => void | boolean; | |
| onHardwareBackPress?: (() => void) | boolean; |
generally would avoid making this a union of a boolean though and use a separate argument, as done in #1083
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes back button in map details