feat: Add device id to About Mapeo screen#989
Conversation
| <DeviceInfoListItem label={t(m.deviceId)} deviceProp="deviceId" /> | ||
| <ListItem> | ||
| <ListItemText | ||
| primary={t(m.deviceId)} | ||
| secondary={displayDeviceId} | ||
| ></ListItemText> | ||
| </ListItem> |
There was a problem hiding this comment.
list item here doesn't seem necessary if you have the DeviceInfoListItem already
There was a problem hiding this comment.
DeviceInfoListItem is a specific wrapper for properties exposed by react-native-device-info.
There was a problem hiding this comment.
tested this locally and somewhat confused about what we want to achieve with this. There are now two Device IDs being listed - one from react-native-device-info and the other from something in the backend? Question is what do we want to display in this case, and can we update the label for one of them to make it clearer about what it is?
There was a problem hiding this comment.
Looks like we need a better name.
This is the public key of the device's writeable hypercore. It is useful for debugging when trying to establish which observations were created on which device. Useful when eg you are analysing a Mapeo project and find missing sparse data in particular hypercore and figuring out which device that is from.
There was a problem hiding this comment.
got it! makes sense after reading the original PR description. few suggestions that come off the top of my head in case any may come relatively close:
- Device Core ID
- Device Data ID
- Device Hypercore ID
- Core ID
- Hypercore ID
- Core Data ID
|
Updated this PR to catch up with develop branch and converted |
2 participants
Not yet tested on a device.
Adds the device id to the About Mapeo screen in settings. The device ID is currently the public key of the writer hypercore for the device. This can be useful for debugging - matching the device to data in the hypercores