Skip to content

feat: initial implementation#1

Merged
gmaclennan merged 9 commits intomainfrom
feat/initial-impl
Dec 11, 2025
Merged

feat: initial implementation#1
gmaclennan merged 9 commits intomainfrom
feat/initial-impl

Conversation

@gmaclennan
Copy link
Member

No description provided.

@gmaclennan gmaclennan self-assigned this Nov 27, 2025
tests ran fine locally, but there is something strange about the github CI environment and how localhost is resolving in node18 to ipv6 that was causing the node18 tests to fail.
@gmaclennan
Copy link
Member Author

The additional test I added in ec49884 is hanging in Ubuntu. What do you think about just skipping that test?

Copy link

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm: This code will only run inside comapeo-core. We'll use it in core to download tiles. The front end will then talk to a regular HTTP server on localhost to fetch tiles to display.

@gmaclennan
Copy link
Member Author

Just to confirm: This code will only run inside comapeo-core. We'll use it in core to download tiles. The front end will then talk to a regular HTTP server on localhost to fetch tiles to display.

Yes, that's what I was thinking. I was imagining that we would use the same http server, just listening on two different ports: one raw http server bound to 127.0.0.1, and the other is the TCP port that wraps the noise exchange, listening on 0.0.0.0. The front end would speak to the server via the port bound to 127.0.0.1 (which doesn't wrap in the noise handshake)

@socket-security
Copy link

socket-security bot commented Dec 10, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addeduint8array-extras@​1.5.010010010081100

View full report

RangerMauve
RangerMauve previously approved these changes Dec 10, 2025
Copy link

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmaclennan gmaclennan merged commit 986ca6b into main Dec 11, 2025
11 checks passed
@gmaclennan gmaclennan deleted the feat/initial-impl branch December 11, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a http server and fetch wrapper for secure http connections over a noise-encrypted stream

2 participants