Conversation
tests ran fine locally, but there is something strange about the github CI environment and how localhost is resolving in node18 to ipv6 that was causing the node18 tests to fail.
|
The additional test I added in ec49884 is hanging in Ubuntu. What do you think about just skipping that test? |
RangerMauve
left a comment
There was a problem hiding this comment.
Just to confirm: This code will only run inside comapeo-core. We'll use it in core to download tiles. The front end will then talk to a regular HTTP server on localhost to fetch tiles to display.
Yes, that's what I was thinking. I was imagining that we would use the same http server, just listening on two different ports: one raw http server bound to 127.0.0.1, and the other is the TCP port that wraps the noise exchange, listening on 0.0.0.0. The front end would speak to the server via the port bound to 127.0.0.1 (which doesn't wrap in the noise handshake) |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
No description provided.