Skip to content

fix: fix file descriptor leak #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmaclennan merged 3 commits into from
Feb 17, 2026
+525 −4
Merged

fix: fix file descriptor leak #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4c86e9
fix: fix file descriptor leak
gmaclennan Feb 17, 2026
a5d38d1
add patch-package
gmaclennan Feb 17, 2026
9f8ac84
fix test for windows
gmaclennan Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/reader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,11 @@ export class Reader {
async close() {
if (this.#closePromise) return this.#closePromise
this.#closePromise = (async () => {
const zip = await this.#zipPromise
// #zipPromise can reject if the file couldn't be opened. Our patch for
// yauzl-promise ensures the zip file is closed in that case, so we can
// just ignore any open error when closing.
const zip = await this.#zipPromise.catch(noop)
if (!zip) return
await zip.close()
})()
return this.#closePromise
Expand Down
Loading
Loading