fix race conditions and memory corruption#4
Open
rofl0r wants to merge 2 commits intodigination:masterfrom
Open
fix race conditions and memory corruption#4rofl0r wants to merge 2 commits intodigination:masterfrom
rofl0r wants to merge 2 commits intodigination:masterfrom
Conversation
replaced the combination of calloc and strncpy with strdup. the latter caused out of bounds writes which corrupted internal malloc state. fixes digination#3
the thread callback function was allocating everything on the heap without good reason, and constructing copies of strings manually with combinations of malloc, strncpy, strncat, etc. i simplified all such sites to use a single snprintf into a stack buffer, which is then passed as argument to curl. additionally i changed the while(queue->head) loop such that the loop is always entered, but the queue head pointer is only fetched when the lock is held, in order to prevent races with other threads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.