avoid duplicate "header" kwarg #144
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes digitalbazaar#133 If headers were passed during call to `requests_document_loader`, these headers will be forced in call to `requests.get`.
anatoly-scherbakov
suggested changes
Oct 18, 2023
| headers = { | ||
| 'Accept': 'application/ld+json, application/json' | ||
| } | ||
| response = requests.get(url, headers=headers, **kwargs) |
There was a problem hiding this comment.
It is unclear how this PR is changing the behavior. From what I am seeing, even before the PR a user could do
requests_document_loader(…, headers={
'Foo': 'bar',
})it should be working on implementation at master. Or am I misunderstanding it?
|
|
||
| headers = {} if 'headers' in kwargs else ({ | ||
| 'headers': ( | ||
| options.get('headers', None) |
There was a problem hiding this comment.
Why we're addressing both kwargs['headers'] and options['headers'], where should those be found?
|
|
||
| DEFAULT_HEADERS = { | ||
| 'Accept': 'application/ld+json, application/json' | ||
| } |
There was a problem hiding this comment.
👍 I appreciate factoring this out as a global constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133
If headers were passed during call to
requests_document_loader,these headers will be forced in call to
requests.get.