Move and refactor remove_base to unresolve function in iri_resolver #216
+126
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mielvds
changed the title
mielvds
force-pushed
the
split-and-test-iri-resolving
branch
from
65201a2 to
fbe2bcf
Compare
mielvds
force-pushed
the
split-remove-base
branch
from
d530c86 to
f480961
Compare
davidlehn
approved these changes
Dec 5, 2025
Member
davidlehn
left a comment
davidlehn
left a comment
There was a problem hiding this comment.
Needs a changelog entry. Could this be a breaking change?
anatoly-scherbakov
approved these changes
Dec 5, 2025
| assert resolve('?y','http://a/bb/ccc/./d;p?q') == 'http://a/bb/ccc/./d;p?y' | ||
|
|
||
| # ---------- Tests for unresolve() ---------- | ||
| class TestUnresolve: |
Collaborator
There was a problem hiding this comment.
Should class-based or function-based pytest testcases be chosen as uniform practice for this project?
Collaborator
Author
There was a problem hiding this comment.
I personally prefer class-based, but I'm fine with both. The only reason why the specs are function-based, is because I couldn't figure out how to make it work otherwise :) What do you think?
Collaborator
There was a problem hiding this comment.
I must confess I never saw pytest class based tests in prod code. Everyone just writes functions after unittest ceased to be de facto standard. But that's just my anecdotal evidence.
mielvds
force-pushed
the
split-and-test-iri-resolving
branch
2 times, most recently
from
66827a9 to
1c521e4
Compare
mielvds
force-pushed
the
split-remove-base
branch
from
fd707e1 to
7f8ea97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and merge #207 first!
This PR
remove_base(base, iri)toiri_resolver.pyand renames it tounresolve(iri, base)(in correspondence withresolve())urlparseandurlunparseremove_base((base, iri))unresolve(iri, base)intests/test_iri_parser.py