#3648-resolved #3738
Open
#3648-resolved #3738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor Svg component to use useMemo for optimization and handle SVG width and height dynamically.
sam2002jain
requested review from
LeandraH,
bahaaTuffaha,
f1sh1918,
lunars97 and
steffenkleinle
as code owners
Member
|
Hey @sam2002jain, thank you so much for all the effort and time spent on this! Sadly, your solution is relatively complicated and a little hacky. @bahaaTuffaha also took a look at this issue and came up with a more easy solution in my opinion, see #3741. I am therefore inclined to go with that solution, sorry for the trouble! 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.