Skip to content

Conversation

@MizukiTemma
Copy link
Member

@MizukiTemma MizukiTemma commented Nov 22, 2024

Short description

This PR adds an pop-up on the statistics page and shows users hints for better interpretation of statistics.

Proposed changes

  • Reuse the functinality of tutorial pop-up for page tree
  • Show the texts suggested by the service team

Side effects

  • In the design the icon ℹ️ should be placed next to "Page access staistics/Seitenzugriffe" (second box under "Total accesses/Anzahl der Online-Zugriffe") but currently implemented next to the title "Statistics", as the box "Page access statistics" is not yet implemented.

Resolved issues

Fixes: #3132


Pull Request Review Guidelines

@MizukiTemma
Copy link
Member Author

Some hints to "see" the pop up

  • Set statistics_tutorial_seen" to true as it is false in the test data.
  • Or click ℹ️ icon next to the title "Statistics"

@JoeyStk JoeyStk self-assigned this Nov 25, 2024
Copy link
Contributor

@lunars97 lunars97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! Everything looks good except for one remark :)

@MizukiTemma MizukiTemma force-pushed the feature/page_access_statistics_popup branch 2 times, most recently from 6defceb to 111a052 Compare November 26, 2024 09:30
@MizukiTemma MizukiTemma requested a review from lunars97 November 26, 2024 09:31
Copy link
Contributor

@lunars97 lunars97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
This looks already quite good. I think the styling needs a few twist, but then this is good to go 🚀
However I spoke with @osmers and this shouldn't be released before #3130, so it might sense to add the blocked label once this is approved and ready :)

@MizukiTemma MizukiTemma added the blocked Blocked by external dependency label Nov 26, 2024
@MizukiTemma MizukiTemma changed the title Add popup for information about page access statistics Add popup for information about page access statistics [Wait for #3130] Nov 26, 2024
@MizukiTemma MizukiTemma force-pushed the feature/page_access_statistics_popup branch from 37e0067 to 2693b5e Compare November 26, 2024 12:44
@MizukiTemma MizukiTemma requested a review from JoeyStk November 26, 2024 12:45
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. Looks good! 🚀

@MizukiTemma MizukiTemma marked this pull request as draft November 28, 2024 21:17
@MizukiTemma MizukiTemma marked this pull request as ready for review November 28, 2024 21:17
@MizukiTemma MizukiTemma marked this pull request as draft November 28, 2024 21:17
@MizukiTemma
Copy link
Member Author

Turned into draft to avoid accidental merge. This PR should be first merged after #3130 is done.

@JoeyStk JoeyStk removed their assignment Dec 7, 2024
@MizukiTemma MizukiTemma force-pushed the feature/page_access_statistics_popup branch 2 times, most recently from 19f83be to 0f363ea Compare December 12, 2024 13:50
@JoeyStk
Copy link
Contributor

JoeyStk commented Mar 7, 2025

@MizukiTemma I think you can wrap this inside the beta permission and merge this now :)

@MizukiTemma
Copy link
Member Author

@JoeyStk

Hmm, how should we go with the position of icon?

In the design the icon ℹ️ should be placed next to "Page access staistics/Seitenzugriffe" (second box under "Total accesses/Anzahl der Online-Zugriffe") but currently implemented next to the title "Statistics", as the box "Page access statistics" is not yet implemented.

If it is adjusted in #3394, I'll merge it hidden by the beta permission.

@JoeyStk
Copy link
Contributor

JoeyStk commented Mar 7, 2025

I'll think about it on Tuesday :)

@JoeyStk
Copy link
Contributor

JoeyStk commented Mar 11, 2025

Hmm, how should we go with the position of icon?

@MizukiTemma Can you not wrap inside the beta permission too? I'm imagining something like {% if perms.cms.beta %} ICON ... . Do you think this would work? :)

@MizukiTemma MizukiTemma force-pushed the feature/page_access_statistics_popup branch from c321fbd to 08687cd Compare April 3, 2025 18:39
@MizukiTemma MizukiTemma force-pushed the feature/page_access_statistics_popup branch 3 times, most recently from 5c75f89 to b13f128 Compare April 15, 2025 13:28
@MizukiTemma MizukiTemma marked this pull request as ready for review April 15, 2025 13:29
Co-authored-by: JoeyStk <72705147+JoeyStk@users.noreply.github.com>
@MizukiTemma MizukiTemma force-pushed the feature/page_access_statistics_popup branch from 9958ee2 to f1d1388 Compare April 15, 2025 13:42
@MizukiTemma MizukiTemma merged commit ef89d0e into develop Apr 15, 2025
5 checks passed
@MizukiTemma MizukiTemma deleted the feature/page_access_statistics_popup branch April 15, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Blocked by external dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2024-12-18] Closable popup for information about page access statistics

4 participants