-
Notifications
You must be signed in to change notification settings - Fork 46
Add popup for information about page access statistics [Wait for #3130] #3231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Some hints to "see" the pop up
|
lunars97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! Everything looks good except for one remark :)
6defceb to
111a052
Compare
lunars97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
JoeyStk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integreat_cms/cms/templates/tutorials/page_access_statistics.html
Outdated
Show resolved
Hide resolved
integreat_cms/cms/templates/tutorials/page_access_statistics.html
Outdated
Show resolved
Hide resolved
integreat_cms/cms/templates/tutorials/page_access_statistics.html
Outdated
Show resolved
Hide resolved
integreat_cms/cms/templates/tutorials/page_access_statistics.html
Outdated
Show resolved
Hide resolved
37e0067 to
2693b5e
Compare
JoeyStk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much. Looks good! 🚀
|
Turned into draft to avoid accidental merge. This PR should be first merged after #3130 is done. |
19f83be to
0f363ea
Compare
|
@MizukiTemma I think you can wrap this inside the beta permission and merge this now :) |
|
Hmm, how should we go with the position of icon?
If it is adjusted in #3394, I'll merge it hidden by the beta permission. |
|
I'll think about it on Tuesday :) |
@MizukiTemma Can you not wrap inside the beta permission too? I'm imagining something like {% if perms.cms.beta %} ICON ... . Do you think this would work? :) |
c321fbd to
08687cd
Compare
5c75f89 to
b13f128
Compare
Co-authored-by: JoeyStk <72705147+JoeyStk@users.noreply.github.com>
9958ee2 to
f1d1388
Compare
Short description
This PR adds an pop-up on the statistics page and shows users hints for better interpretation of statistics.
Proposed changes
Side effects
Resolved issues
Fixes: #3132
Pull Request Review Guidelines