Handle chat back end exceptions #4035
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenseeberg
force-pushed
the
feat/handle-chat-back-end-exceptions
branch
3 times, most recently
from
b4148b3 to
92d23da
Compare
svenseeberg
force-pushed
the
feat/handle-chat-back-end-exceptions
branch
from
92d23da to
90816ab
Compare
MizukiTemma
approved these changes
Dec 2, 2025
jonbulz
approved these changes
Dec 4, 2025
| aiohttp.client_exceptions.ServerDisconnectedError, | ||
| aiohttp.client_exceptions.ClientConnectionError, | ||
| ): | ||
| logger.exception("Failed to get response from chat back end.") |
Contributor
There was a problem hiding this comment.
Could be helpful to log which exception was caught, maybe? But this also works for me 👍
Member
Author
There was a problem hiding this comment.
I think connection problems are usually very easy to debug and don't need the details. The message should be improved though:
Failed to get response from chat back end due to connection error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
In some cases the chat back runs into unexpected errors which usually only imply that no answer could be generated for the user. This PR catches the most important ones, logs them, and turns the typing indicator off, so that the user does not expect messages that will never come.
Proposed changes
Side effects
Faithfulness to issue description and design
This improves the UX as asked for in digitalfabrik/integreat-chat#362
How to test
Turn off chat back end and send message. The typing indicator should turn off before the 60s cache expires.
Resolved issues
Fixes: digitalfabrik/integreat-chat#362
Pull Request Review Guidelines