Rename contact opening hours to office hours & add office hours to cards & #4066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterNerlich
force-pushed
the
feature/office-hours
branch
from
d6c6417 to
36b8121
Compare
PeterNerlich
force-pushed
the
feature/office-hours
branch
from
36b8121 to
7325dd4
Compare
PeterNerlich
requested review from
MizukiTemma,
hannaseithe,
jarlhengstmengel and
jonbulz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR renames the verbose name of contact opening hours to office hours, adds office hours to contact cards and transforms the opening hours of contacts to contain the timezones (as we already do it for POIs).
Proposed changes
Side effects
Faithfulness to issue description and design
There are no intended deviations from the issue and design.
There are some deviations from the design:
a. opening office hours in the contact card is not possible (bcs contact cards are non-editable objects)
b. showing the current day on the contact card is also not possible (at least as long as we don't have shortcodes)
I will talk to the POs about it.
How to test
TBD
Resolved issues
Fixes: #4006
Fixes: #3659 (partly)
Pull Request Review Guidelines