Skip to content

Conversation

@jarlhengstmengel
Copy link
Contributor

Short description

Add handling of multiple requests for page access statistics.

Proposed changes

  • Add ajaxRequestID to track if there was another request after the current one

Side effects

  • None

Faithfulness to issue description and design

There are no intended deviations from the issue and design.

How to test

The main thing to test here, is if everything works as expected. The original bug is really hard to reproduce after the speedup of the requests. But since the requests are async, it's probably not to bad to have this watertight.

To test everything works fine without loading a data dump you need statistics to be activated.

  • Go to the region settings of e.g. Augsburg on the test system and copy the matomo auth token
  • Run the cms locally and go to the region settings of Augsburg
  • Check the statistics Checkbox and paste the matomo auth token
  • Run the fetch page accesses management command: integreat-cms-cli fetch_page_accesses --start-date START_DATE --end-date END_DATE --region-slug augsburg (start and end date can be the same, good pick would be yesterday)
  • Wait for about 30 to 40 sec
  • Go to the statistics page for Augsburg
  • See that everything works fine

Bugs with the loading indication and uncaught type errors are handeld by #4060

Resolved issues

Fixes: #3941


Pull Request Review Guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple requests for page based statistics loading at the same time

2 participants