Handle multiple requests pge accesses at the same time #4072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Add handling of multiple requests for page access statistics.
Proposed changes
ajaxRequestIDto track if there was another request after the current oneSide effects
Faithfulness to issue description and design
There are no intended deviations from the issue and design.
How to test
The main thing to test here, is if everything works as expected. The original bug is really hard to reproduce after the speedup of the requests. But since the requests are async, it's probably not to bad to have this watertight.
To test everything works fine without loading a data dump you need statistics to be activated.
integreat-cms-cli fetch_page_accesses --start-date START_DATE --end-date END_DATE --region-slug augsburg(start and end date can be the same, good pick would be yesterday)Bugs with the loading indication and uncaught type errors are handeld by #4060
Resolved issues
Fixes: #3941
Pull Request Review Guidelines