getVariantsAllProducts, getProducts, Product (not from order), ImageResource#12
Open
MagicStino wants to merge 4 commits intodigitaport:masterfrom
Open
getVariantsAllProducts, getProducts, Product (not from order), ImageResource#12MagicStino wants to merge 4 commits intodigitaport:masterfrom
MagicStino wants to merge 4 commits intodigitaport:masterfrom
Conversation
Contributor
|
You've butchered the package-lock. Please revert it. Types file looks wrong, types should end with a semicolon. |
Author
Thanks, I'm a novice in node/npm/git I tried to follow up your instructions. Hope I did wright. Should I exclude package-lock.json in the future? |
Contributor
|
Just depends on if you have changes. You don't so the package-lock shouldn't change. |
…oduct types declarations
Author
|
fixed, must had being tired. compiled fine though ;) And thanks for feedback on package-lock. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a function to retrieve all existing product variants from ecom shop (not from order).
Added a function to retrieve all products for ecom shop, added simple Product Type and for that added ImageResource