Support parens in links#154
Open
Janiczek wants to merge 1 commit intodillonkearns:masterfrom
Open
Conversation
Janiczek
force-pushed
the
janiczek-parens-in-links
branch
from
ed4ce81 to
da2322e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153
Makes CommonMark 495 pass:
[link](foo(and(bar)))The issue with keeping the existing regex approach for me was that we needed to balance the parentheses. Maybe there is some lookahead / lookbehind regex magic that could do this, but I didn't figure it out.
So instead we walk the string and count
(and)as we go.Also, the E2E test
new/link_ltkept popping up as newly failing. But both Commonmark and Marked.js demo playgrounds kept giving me a different result than elm-markdown test suite expected, so I opted to fix that test.