QA-8465 - Added missing Hausa translation#3630
QA-8465 - Added missing Hausa translation#3630Jignesh-dimagi wants to merge 2 commits intocommcare_2.62from
Conversation
📝 WalkthroughWalkthroughThis change updates localized string resources across multiple language files (Spanish, French, Hindi, Portuguese, Swahili, Tigrinya, and English) by renaming the Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can enable review details to help with troubleshooting, context usage and more.Enable the |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/res/values-ha/strings.xml`:
- Around line 386-390: Add the missing string resource named continue_label to
the Hausa strings resource so the locale no longer falls back to default; update
the strings.xml entry by adding a <string name="continue_label">...</string>
with the Hausa translation (e.g., "Ci gaba" or the correct localized wording)
near other UI labels (see existing keys like commcare_welcome_label and
installation_method_label) to ensure the continue button/localized text is
present for Hausa users.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: d3a305d8-c62b-471a-a484-97f8ffee04f1
📒 Files selected for processing (9)
app/res/values-es/strings.xmlapp/res/values-fr/strings.xmlapp/res/values-ha/strings.xmlapp/res/values-hi/strings.xmlapp/res/values-pt/strings.xmlapp/res/values-sw/strings.xmlapp/res/values-ti/strings.xmlapp/res/values/strings.xmlapp/src/org/commcare/fragments/SelectInstallModeFragment.java
| setupMsg.setText(getString(R.string.commcare_welcome_label)); | ||
|
|
||
| TextView setupMsg2 = view.findViewById(R.id.str_setup_message_2); | ||
| setupMsg2.setText(Localization.get("install.barcode.bottom")); | ||
| setupMsg2.setText(getString(R.string.installation_method_label)); |
There was a problem hiding this comment.
-
There are bunch of other such strings in https://github.com/dimagi/commcare-android/blob/master/app/assets/locales/android_startup_strings.txt , and if we are moving one of them we should move all of them.
-
These strings still need to support app translations and therefore we will need to use
getStringRobusthere. -
We should not change the naming here and call them
install_barcode_top(replace . with _) instead in strings.xml as there might be HQ apps out there that already defines these strings and we don't want to suddently break those apps
|
|
||
|
|
||
| <string name="connect_recovery_button_phone">Continue</string> | ||
| <string name="continue_label">Continue</string> |
There was a problem hiding this comment.
Renaming the string resource like this breaks our guidelines for strings in the app, specifically this point:
Please name the strings as per the code area they are used in and group strings together as per the screen they are used in (Eg. personalid_ and connect_ prefixes)
What if we added the connect_ prefix back in?
Product Description
This PR will add the few translation strings to all languages, and it is adding the missing string for Hausa translation.
Technical Summary
https://dimagi.atlassian.net/browse/QA-8465
Added more strings to the Hausa translation. The strings added have the following statistics:
147 strings are added and used via R.string.* in code
17 strings are added and used in XML layouts/menus/manifest
This PR also adds 2 more strings,
commcare_welcome_labelandinstallation_method_label, which are getting displayed on the CommCare setup activity. Previously, it was dependent upon the HQ CommCare app translation, but it should be independent of that, so it was added to the strings.xml resource.This PR also add string
continue_labelto localisation.The mentioned QA ticket also demands translation for push notifications, which is not supported as of now.
Also, there is a mention of a PIN/biometric pop-up missing translations. I think that's the default behaviour of Android, which cannot be modified.
Labels and Review