Open
Conversation
040d972 to
a48bfe0
Compare
AmitPhulera
reviewed
Feb 25, 2026
AmitPhulera
reviewed
Feb 25, 2026
AmitPhulera
reviewed
Feb 25, 2026
AmitPhulera
reviewed
Feb 25, 2026
AmitPhulera
reviewed
Feb 25, 2026
AmitPhulera
reviewed
Feb 25, 2026
Contributor
AmitPhulera
left a comment
There was a problem hiding this comment.
Generally looking good, have left some suggestions.
Co-authored-by: Amit Phulera <amitphulera999@gmail.com>
Co-authored-by: Amit Phulera <amitphulera999@gmail.com>
Co-authored-by: Amit Phulera <amitphulera999@gmail.com>
Co-authored-by: Amit Phulera <amitphulera999@gmail.com>
Co-authored-by: Amit Phulera <amitphulera999@gmail.com>
AmitPhulera
reviewed
Feb 27, 2026
|
|
||
| ```sh | ||
| git commit -am "Update CouchDB version to 3.4.3" | ||
| git push |
Contributor
There was a problem hiding this comment.
Is pushing the changes required?
Contributor
Author
There was a problem hiding this comment.
Is pushing the changes required?
It is required because it sends the committed changes to the remote repository.
Contributor
There was a problem hiding this comment.
git commit -am "Update CouchDB version to 3.4.3"
This commands adds everything in the changes and commits it. Can we just add the file that is updated.
It is required because it sends the committed changes to the remote repository.
Yes that is true but we are not sure if the users are actually tracking it in a remote repo. I would suggest add ask them if they want they can push the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding CouchDB upgrade instructions
Ticket : https://dimagi.atlassian.net/browse/SAAS-18754