Open
Conversation
AmitPhulera
commented
Feb 24, 2026
| policy_arn = "arn:aws:iam::aws:policy/AmazonSSMManagedInstanceCore" | ||
| } | ||
|
|
||
| resource "aws_iam_role_policy" "control_request_response_stream_put_policy" { |
Contributor
Author
There was a problem hiding this comment.
I think we can remove this because we are not shipping any control logs via firehose?
AmitPhulera
commented
Feb 24, 2026
| POLICY | ||
| } | ||
|
|
||
| resource "aws_iam_role_policy" "control_access_s3_kiss_upload" { |
Contributor
Author
There was a problem hiding this comment.
This probably is outdated and should be removed from CommCareServerRole as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new server role
CommCareControlServerRolewhich has all the permissions fromCommCareServerRolebut adds the ability to Stop, Start instances.I have some questions regarding removing things from the new role which probably would not be required for control machine which I have asked as comments on the PR.
Another thing to note here is that we have added
iam_instance_profileto theignore_changesin the terraform lifecycle rules. So to apply these changes, we would have to removeiam_instance_profilefromcommcare-cloud/src/commcare_cloud/terraform/modules/server/main.tf
Lines 27 to 30 in 1881e57
And then apply the changes and then add it back.
Environments Affected
All