Skip to content

Partially reverse "Make language slug available via session metadata"#1447

Merged
minhaminha merged 1 commit intoformplayerfrom
ml/partially-reverse-lang-slug-metadata-work
Oct 23, 2024
Merged

Partially reverse "Make language slug available via session metadata"#1447
minhaminha merged 1 commit intoformplayerfrom
ml/partially-reverse-lang-slug-metadata-work

Conversation

@minhaminha
Copy link
Contributor

@minhaminha minhaminha commented Oct 23, 2024

Product Description

Users will still be able to reference the current screen's language slug using instance('commcaresession')/session/context/applanguage

Improvement over #1441

Associated dimagi/formplayer#1630

Technical Summary

Shubham pointed out there is an existing function Localization.getCurrentLocale() that eliminates the need for convoluted ways to pass along the locale value from the initial BaseResponseBean.

Safety Assurance

Safety story

Tested locally and on staging. No data impact as the metadata refreshes with every navigation request.

QA Plan

Will have delivery try out their tests once more before merging.

Special deploy instructions

  • This PR can be deployed after merge with no further considerations.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

Duplicate PR

Automatically duplicate this PR as defined in contributing.md.

@minhaminha minhaminha merged commit 67bcb5a into formplayer Oct 23, 2024
@minhaminha minhaminha deleted the ml/partially-reverse-lang-slug-metadata-work branch October 23, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants