removes duplicate entity skip change

[shubham1g5]

Product Description

No user visible change

Technical Summary

This change was incorrectly retained in master while it was removed from formplayer in this branch

Safety Assurance

This class only affects CLI/Formplayer which doesn't have this code already in formplayer branch and this change is just to better reconcile the 2 branches.

Special deploy instructions

• This PR can be deployed after merge with no further considerations.

Rollback instructions

• This PR can be reverted after deploy with no further considerations.

Review

• The set of people pinged as reviewers is appropriate for the level of risk of the change.

Duplicate PR

Automatically duplicate this PR as defined in contributing.md.

Summary by CodeRabbit

• Refactor
  • Reorganized internal initialization sequencing to improve code maintainability. Observable functionality remains unchanged.

[coderabbitai]

Walkthrough

Refactored EntityScreen initialization by deferring EntityListSubscreen instantiation from initReferences() to initListSubScreen(). The subscreen is created with the same conditional logic based on readyToSkip, needsFullInit, and isDetailScreen. Observable behavior unchanged; initialization sequencing modified.

Changes

Cohort / File(s)	Summary
Subscreen Initialization Refactoring src/cli/java/org/commcare/util/screen/EntityScreen.java	Removed eager EntityListSubscreen instantiation from initReferences() and moved subscreen creation logic to initListSubScreen() with conditional handling based on readyToSkip, needsFullInit, and isDetailScreen flags

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant EntityScreen
    
    rect rgb(200, 220, 255)
    Note over EntityScreen: Before (eager initialization)
    Client->>EntityScreen: EntityScreen initialization
    EntityScreen->>EntityScreen: initReferences()
    Note over EntityScreen: Compute references & context
    EntityScreen->>EntityScreen: Check readyToSkip
    alt not readyToSkip
        EntityScreen->>EntityScreen: Create EntityListSubscreen
    end
    end
    
    rect rgb(220, 255, 220)
    Note over EntityScreen: After (deferred initialization)
    Client->>EntityScreen: EntityScreen initialization
    EntityScreen->>EntityScreen: initReferences()
    Note over EntityScreen: Compute references & context only
    EntityScreen->>EntityScreen: initListSubScreen()
    Note over EntityScreen: Check readyToSkip
    alt not readyToSkip
        EntityScreen->>EntityScreen: Create EntityListSubscreen
    end
    end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

The refactoring is straightforward: conditional logic and instantiation moved between methods without behavioral changes. Primary review focus: verify the moved code retains identical semantics and parameters in the new location, and confirm the initialization sequencing doesn't introduce timing issues.

Poem

🐰 Initialization hops in sequence neat,
First references, then subscreen—the dance complete!
Deferred wisdom, same result in sight,
Refactoring magic done just right! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "removes duplicate entity skip change" is clearly related to the main changeset, which involves removing a conditional block from the EntityScreen initialization logic that was incorrectly retained in master while having been removed from the formplayer branch. The title accurately conveys that this is about removing duplicate code and specifically references the entity skip-related change (the conditional block handling readyToSkip logic). While the phrasing of "entity skip change" could be more explicit for developers unfamiliar with this codebase area, it is sufficiently specific and descriptive to indicate the primary purpose of the changeset when combined with the PR objectives.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch removeDuplicateEntityScreenChange

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2361d31 and dd8437a.

📒 Files selected for processing (1)

• src/cli/java/org/commcare/util/screen/EntityScreen.java (0 hunks)

💤 Files with no reviewable changes (1)

• src/cli/java/org/commcare/util/screen/EntityScreen.java

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[shubham1g5]

@avazirna bumping on this, I want to get this in before #1506