use instance_id_ variables For Multi Select Endpoints#1458
Closed
shubham1g5 wants to merge 1 commit intomasterfrom
Closed
use instance_id_ variables For Multi Select Endpoints#1458shubham1g5 wants to merge 1 commit intomasterfrom
shubham1g5 wants to merge 1 commit intomasterfrom
Conversation
Contributor
Author
|
@snopoke This needs cleanup but I kind of just want to get a OK on the approach here before making further changes here and on HQ. This concern came up whille working on inline case search changes which might need us to retain both the original argument value along with the substituted instance argument and I would prefer to keep the actual argument name as it is. I confirmed with delivery that this is not deployed yet in any of their apps so should not need backward compatibility. |
snopoke
reviewed
Sep 6, 2023
Contributor
snopoke
left a comment
There was a problem hiding this comment.
I don't really like this approach because it depends on some internal naming convention in the engine.
I made this comment on the spec as well but could not use the instance to get the list of case IDs in the query:
<data key="case_id" nodeset="instance('selected_cases')/results/value" ref="."/>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical Summary
This is a modification on top of the multi-select session endpoints support. Instead of substituting the instance arguments directly, use a prefix
instance_id_argnameto signify that we want to substitue the argument with corresponding instance guid.Safety Assurance
Safety story
Automated test coverage
QA Plan
Migrations
Special deploy instructions
Rollback instructions
Review
cross-request: dimagi/commcare-core#1327