Point commcare-core submodule at master branch#1767
Conversation
The formplayer branch has been deleted. Both commcare-android and formplayer now use master, with cross-repo CI ensuring compatibility. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1767 +/- ##
============================================
- Coverage 70.12% 70.09% -0.03%
+ Complexity 2030 2029 -1
============================================
Files 257 257
Lines 8009 8009
Branches 763 763
============================================
- Hits 5616 5614 -2
- Misses 2110 2112 +2
Partials 283 283 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| path = libs/commcare | ||
| url = https://github.com/dimagi/commcare-core.git | ||
| branch = formplayer No newline at end of file | ||
| branch = master No newline at end of file |
There was a problem hiding this comment.
Looking at the diff on the libs/commcare change, it looks like the only additional PRs that were merged into master but weren't yet on the formplayer branch at the time that we deleted it were dimagi/commcare-core#1521 and dimagi/commcare-core#1516.
(There are a few other PRs, but they are all PRs that only touch GHA workflows under .github/ and docs/ and so categorically could not break formplayer by incorporating them.)
There was a problem hiding this comment.
Tests have of course been run against this, so that adds some level of assurance, but just wanted to raise in case anyone wants to advocate for more deeper testing/QA.
https://dimagi.atlassian.net/browse/SAAS-19426
Product Description
No user-facing changes. Infrastructure cleanup only.
Technical Summary
Part of the formplayer branch elimination effort. The commcare-core
formplayerbranch has been deleted — both commcare-android and formplayer now usemaster, with cross-repo CI (commcare-core PR #1525) ensuring compatibility.This PR:
.gitmodulesto trackmasterinstead of the deletedformplayerbranchmasterHEADSafety Assurance
Safety story
The commcare-core
masterandformplayerbranches were already reconciled before theformplayerbranch was deleted. This change points the submodule at the same code on a different branch name.Automated test coverage
CI will verify that formplayer builds and tests pass with the submodule pointing at
master.QA Plan
Special deploy instructions
Rollback instructions
Review