Skip to content

Improve system schedules#584

Merged
ThierryBerger merged 10 commits intodimforge:masterfrom
ThierryBerger:system_schedules
Sep 20, 2024
Merged

Improve system schedules#584
ThierryBerger merged 10 commits intodimforge:masterfrom
ThierryBerger:system_schedules

Conversation

@ThierryBerger
Copy link
Contributor

@ThierryBerger ThierryBerger commented Sep 6, 2024

This builds on top of #576 to more easily visualize the impacts

  • avoid systems in multiple sets:

This change doesn´t impact the execution, but orders systems more consistently, leading to simpler representation possible and less cognitive load.

Before

multiple sets propagate

After

Child system set

To be noted I'm not entirely sure keeping this RapierTransformPropagateSet is necessary, as a user might eventually want to order systems after systems, and there's no ambiguous beginning or end to this set.

Further improvements (out of scope)

Split RapierContext

There are systems running sequentially, but each write to different parts of RapierContext.

image

If we split RapierContext's:

  • joints
  • colliders
  • bodies

We'd be able to parallelize some systems execution.

Copy link
Member

@sebcrozet sebcrozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ThierryBerger ThierryBerger merged commit 3cf2b93 into dimforge:master Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants