Skip to content

Conversation

@tfitch
Copy link

@tfitch tfitch commented Apr 22, 2025

Change

Update for issue #85 to add the number of changed resources or outputs to the summary reports.

Note

This did not get linted because when I installed golanglint-ci it was a newer version (2.1.2) and wanted to update the .golangci.yaml file. I'll leave that to you.
Directly running go test passes.

Update for issue dineshba#85 to add the number of changed resources or
outputs to the summary reports.

Signed-off-by: Tyler Fitch <github@tfitch.com>
@brunoarruda-hotmart
Copy link

Hi @dineshba, I’ve been following this PR and it looks great! Just wondering if there’s anything pending for it to be merged. Thanks for your time!
And thank you @tfitch for your contribution.

@dineshba
Copy link
Owner

dineshba commented Jan 8, 2026

Hey sorry folks... I missed to merge this PR. Now it got conflict. I will merge this within this week.

@tfitch Need your help to resolve conflicts in this PR cc: @brunoarruda-hotmart

@tfitch
Copy link
Author

tfitch commented Jan 9, 2026

Hi @dineshba I'll try and get this sorted out this weekend. What was my one line in writer/html_test.go got completely refactored when that whole section of validating my change was removed in https://github.com/dineshba/tf-summarize/pull/97/files#diff-c4ae7acd1d29d7303351ffc50b955eb57ad7763bbc9e3a96cc5ae4f4d7eead58L12

So I don't trust doing the browser based conflict review, I'll have to get on my personal laptop and do the full test and validation with the latest from the main branch.
I could accept the latest from main but then there's no validation of my change in the HTML output which is less than ideal. So if I can, I'll find a new validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants