-
-
Notifications
You must be signed in to change notification settings - Fork 199
fix(ui): 服务商表单小屏体验与客户端限制配置 #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
48532ae
d70d66d
c9b77fe
884340e
68a6553
b9f1ebf
6887c5b
4886ad1
7f8d184
e7a9136
674c55c
e88440a
6265bdc
cc61d09
a98ec3a
5a1290d
29fe9e1
38fb971
059ecd7
bc9cdf5
c147c91
eef2765
a7573cb
348c5f7
72fb6ba
1e194ee
8ad5970
e05288b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ | |
| "routing": "路由", | ||
| "limits": "限制", | ||
| "network": "网络", | ||
| "testing": "测试" | ||
| "testing": "测试", | ||
| "stepProgress": "步骤进度" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ | |
| "routing": "路由", | ||
| "limits": "限制", | ||
| "network": "網路", | ||
| "testing": "測試" | ||
| "testing": "測試", | ||
| "stepProgress": "步驟進度" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -244,7 +244,7 @@ function EditUserDialogInner({ onOpenChange, user, onSuccess }: EditUserDialogPr | |||||
| }; | ||||||
|
|
||||||
| return ( | ||||||
| <DialogContent className="w-full max-w-[95vw] sm:max-w-[85vw] md:max-w-[70vw] lg:max-w-3xl max-h-[90vh] max-h-[90dvh] p-0 flex flex-col overflow-hidden"> | ||||||
| <DialogContent className="w-full max-w-[95vw] sm:max-w-[85vw] md:max-w-[70vw] lg:max-w-3xl max-h-[var(--cch-viewport-height-90,90vh)] p-0 flex flex-col overflow-hidden"> | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Inconsistent CSS variable fallback usage This file uses Since
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: src/app/[locale]/dashboard/_components/user/edit-user-dialog.tsx
Line: 247
Comment:
**Inconsistent CSS variable fallback usage**
This file uses `max-h-[var(--cch-viewport-height-90,90vh)]` with an inline fallback, while the other ~30 files changed in this PR use the variable without a fallback (e.g., `max-h-[var(--cch-viewport-height-90)]`). The same inconsistency exists in `user-actions.tsx:43` with `--cch-viewport-height-85,85vh`.
Since `globals.css` already defines `--cch-viewport-height-90: 90vh` as the default, the inline fallback is redundant. For consistency, either add the fallback everywhere or remove it here.
```suggestion
<DialogContent className="w-full max-w-[95vw] sm:max-w-[85vw] md:max-w-[70vw] lg:max-w-3xl max-h-[var(--cch-viewport-height-90)] p-0 flex flex-col overflow-hidden">
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||
| <form onSubmit={form.handleSubmit} className="flex flex-1 min-h-0 flex-col"> | ||||||
| <DialogHeader className="px-6 pt-6 pb-4 border-b flex-shrink-0"> | ||||||
| <div className="flex items-center gap-2"> | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.