Fixes a bug with names that have three+ spaces#2
Open
bongochong wants to merge 5 commits intodinhnerz:masterfrom
Open
Fixes a bug with names that have three+ spaces#2bongochong wants to merge 5 commits intodinhnerz:masterfrom
bongochong wants to merge 5 commits intodinhnerz:masterfrom
Conversation
This very small change resolves an issue where assets that have three or more spaces in their names would not have the final space converted to a hyphen, resulting in the user getting an error page on CoinMarketCap instead.
Author
|
I also noticed two PDF files - which I assume were accidentally uploaded - in the images directory. Probably should be removed. |
Author
|
My pull request now contains updates to bootstrap and jquery, along with removal of your accidentally added PDF files in the images subdirectory. I have tested the extension with the modifications included in this pull request and it works perfectly. I hope you eventually get around to merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This very small change resolves an issue where assets that have three or more spaces in their names would not have the final space converted to a hyphen, resulting in the user getting an error page on CoinMarketCap instead.