Respect distance units when ordering by distance#50
Open
cgunther wants to merge 1 commit intodiogob:masterfrom
Open
Respect distance units when ordering by distance#50cgunther wants to merge 1 commit intodiogob:masterfrom
cgunther wants to merge 1 commit intodiogob:masterfrom
Conversation
While the unit shouldn't change the result, if you order and select with a distinct call (ie. `Model.distinct.selecting_distance_from(...).order_by_distance(...)`), Postgres requires all ordering values to also be selected. Previously, in such a case, we'd be selecting by miles when that was the configured unit, but then ordering by meters, which Postres didn't like. Now, we'll both select miles and order by miles when configured as such.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the unit shouldn't change the result, if you order and select with a distinct call (ie.
Model.distinct.selecting_distance_from(...).order_by_distance(...)), Postgres requires all ordering values to also be selected.Previously, in such a case, we'd be selecting by miles when that was the configured unit, but then ordering by meters, which Postres didn't like.
Now, we'll both select miles and order by miles when configured as such.