Skip to content

Comments

Support for hasql-1.9#109

Merged
diogob merged 2 commits intomasterfrom
hasql-1.9
Sep 7, 2025
Merged

Support for hasql-1.9#109
diogob merged 2 commits intomasterfrom
hasql-1.9

Conversation

@diogob
Copy link
Owner

@diogob diogob commented Sep 4, 2025

This update should take care of #108

@diogob diogob linked an issue Sep 4, 2025 that may be closed by this pull request
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and tests pass for GHC 9.6, GHC 9.8 and GHC 9.10 in Nixpkgs.

Trying with GHC 9.12 I get this:

Encountered missing or private dependencies:
    time >=1.8.0.2 && <1.13

When I ignore that constraint, it builds and tests fine with GHC 9.12 as well. Might want to relax that constraint at the same time.

@diogob
Copy link
Owner Author

diogob commented Sep 7, 2025

@wolfgangwalther thanks for the review and tests.

@diogob diogob marked this pull request as ready for review September 7, 2025 15:17
@diogob diogob merged commit 525921c into master Sep 7, 2025
1 check passed
@diogob diogob deleted the hasql-1.9 branch September 7, 2025 18:51
@diogob
Copy link
Owner Author

diogob commented Sep 7, 2025

I forgot to relax the library dependency on this PR but will update before releasing the new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Currently fails to build with hasql 1.9 / hasql-pool 1.3

2 participants