More general plot class for arbitrary geometry, not only sp2#121
Open
More general plot class for arbitrary geometry, not only sp2#121
Conversation
…atch collection to plot the atomic structure and not only the one for sp2 systems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way in which we plotted geometry-related plots was specific for sp2 carbon systems, however we can easily generalize this for now by allowing to pass any other patch collection that the user may want to use.
It is still default to the sp2 case to minimize the changes, but maybe it should be established the
Nonecase as the default value?