Deterministic file order (in the TOC) for Generic Includer #1420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3y3
force-pushed
the
master
branch
16 times, most recently
from
2698a95 to
cfe7e59
Compare
Author
|
ping? |
| }); | ||
| } | ||
|
|
||
| sortGlobResult(files: NormalizedPath[]): NormalizedPath[] { |
Contributor
There was a problem hiding this comment.
please add tests for this behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix random order in the TOC, when using Generic Includer (doc readers may be confused).
Sort from the shortest paths to longest (by path segments).
Put
index.mdas the first item in the TOC (it seems to be useful for the most of use cases).