Skip to content

fix: fixed localisation for notes block #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ekiuled wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: fixed localisation for notes block #943

ekiuled wants to merge 1 commit into from

Conversation

@ekiuled
Copy link

@ekiuled ekiuled commented Dec 14, 2024

Description

Fixed localisation for notes block: pass file language to notes pluging instead of always using yfm args.

Related issue: #890

@martyanovandrey
Copy link
Contributor

martyanovandrey commented Dec 27, 2024

Thank you for your contribution! Here are a few points that need to be addressed:

  1. I built our documentation with the changes from the current pull request, but I still encountered an error regarding the section titles being in Russian. Could you please let me know which documentation you tested on and with what parameters you ran the build? This information will help us identify the issue more effectively.

  2. To facilitate the validation of this PR, it would be helpful to include tests. Tests will ensure that everything is functioning as expected and make it easier for us to proceed with the integration.

  3. The generateStaticMarkup function is raising an error due to missing type definitions.

Once these issues have been addressed, we can proceed with further review. Thank you for your efforts!

@3y3 3y3 force-pushed the master branch 2 times, most recently from d81a901 to 0e15f40 Compare February 3, 2025 21:29
@3y3 3y3 force-pushed the master branch 2 times, most recently from 46acb0a to b4bcc4d Compare March 27, 2025 09:41
@3y3 3y3 force-pushed the master branch 5 times, most recently from c7ab6c3 to 14d671e Compare August 26, 2025 09:04
@3y3 3y3 force-pushed the master branch 9 times, most recently from 52f2688 to 50a4135 Compare September 15, 2025 14:36
@3y3 3y3 force-pushed the master branch 5 times, most recently from 1d1fed8 to b47c7f3 Compare September 22, 2025 16:53
@3y3 3y3 force-pushed the master branch 11 times, most recently from 2698a95 to cfe7e59 Compare September 22, 2025 18:21
@3y3 3y3 requested a review from a team as a code owner December 23, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3y3 3y3 3y3 approved these changes

@martyanovandrey martyanovandrey Awaiting requested review from martyanovandrey

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ekiuled @martyanovandrey @3y3