fix: setServiceAndID watcher as immediate#231
Open
remihuigen wants to merge 2 commits intodirectus-labs:mainfrom
Open
fix: setServiceAndID watcher as immediate#231remihuigen wants to merge 2 commits intodirectus-labs:mainfrom
remihuigen wants to merge 2 commits intodirectus-labs:mainfrom
Conversation
By setting the watcher to immediate, the id and service refs are populated when the components mount
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an initialization issue where the video interface component doesn't display the selected video file when mounting with an existing ID value. The fix makes the watcher that handles service and ID initialization run immediately on component mount.
- Updated the
props.valuewatcher to include theimmediate: trueoption
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The id ref does not get populated when the component mounts, showing a video interface without a selected video file (even if the component props have an id value)
Solution
Set the responsible watcher
immediateprop to true